Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Come up with a more elegant solution for base_url than ds.urls.path() #1523

Open
simonw opened this issue Nov 20, 2021 · 0 comments
Open

Come up with a more elegant solution for base_url than ds.urls.path() #1523

simonw opened this issue Nov 20, 2021 · 0 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Nov 20, 2021

While fixing #1519 I added a lot of ugly code that looks like this:

"toggle_url": ds.urls.path(
path_with_removed_args(self.request, {"_facet": column})
),

See these two commits in particular: fe687fd and 08947fa

It would be great to come up with a less verbose and error-prone way of handling this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant