From c5ae1197a208e1b034c88882e3ac865813a40980 Mon Sep 17 00:00:00 2001
From: Simon Willison <swillison@gmail.com>
Date: Sun, 30 May 2021 22:39:14 -0400
Subject: [PATCH] ?_nofacets=1 option, closes #1350

---
 datasette/views/table.py | 16 +++++++++-------
 docs/facets.rst          |  2 ++
 docs/json_api.rst        |  3 +++
 tests/test_api.py        | 14 ++++++++++++++
 4 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/datasette/views/table.py b/datasette/views/table.py
index c570329222..83c2b922a5 100644
--- a/datasette/views/table.py
+++ b/datasette/views/table.py
@@ -731,13 +731,14 @@ async def data(
                 )
             )
 
-        for facet in facet_instances:
-            (
-                instance_facet_results,
-                instance_facets_timed_out,
-            ) = await facet.facet_results()
-            facet_results.update(instance_facet_results)
-            facets_timed_out.extend(instance_facets_timed_out)
+        if not request.args.get("_nofacets"):
+            for facet in facet_instances:
+                (
+                    instance_facet_results,
+                    instance_facets_timed_out,
+                ) = await facet.facet_results()
+                facet_results.update(instance_facet_results)
+                facets_timed_out.extend(instance_facets_timed_out)
 
         # Figure out columns and rows for the query
         columns = [r[0] for r in results.description]
@@ -828,6 +829,7 @@ async def data(
             self.ds.setting("suggest_facets")
             and self.ds.setting("allow_facet")
             and not _next
+            and not request.args.get("_nofacets")
         ):
             for facet in facet_instances:
                 suggested_facets.extend(await facet.suggest())
diff --git a/docs/facets.rst b/docs/facets.rst
index 5061d11cea..7730e4ac6f 100644
--- a/docs/facets.rst
+++ b/docs/facets.rst
@@ -86,6 +86,8 @@ If Datasette detects that a column is a foreign key, the ``"label"`` property wi
 
 The default number of facet results returned is 30, controlled by the :ref:`setting_default_facet_size` setting. You can increase this on an individual page by adding ``?_facet_size=100`` to the query string, up to a maximum of :ref:`setting_max_returned_rows` (which defaults to 1000).
 
+.. _facets_metadata:
+
 Facets in metadata.json
 -----------------------
 
diff --git a/docs/json_api.rst b/docs/json_api.rst
index e48ec51456..62c208a287 100644
--- a/docs/json_api.rst
+++ b/docs/json_api.rst
@@ -383,6 +383,9 @@ Special table arguments
 ``?_facet_size=100``
     Increase the number of facet results returned for each facet. Use ``?_facet_size=max`` for the maximum available size, determined by :ref:`setting_max_returned_rows`.
 
+``?_nofacets=1``
+    Disable all facets and facet suggestions for this page, including any defined by :ref:`facets_metadata`.
+
 ``?_trace=1``
     Turns on tracing for this page: SQL queries executed during the request will
     be gathered and included in the response, either in a new ``"_traces"`` key
diff --git a/tests/test_api.py b/tests/test_api.py
index 2c5d7516f5..3d6d03305c 100644
--- a/tests/test_api.py
+++ b/tests/test_api.py
@@ -1669,6 +1669,20 @@ def test_suggest_facets_off():
         assert [] == client.get("/fixtures/facetable.json").json["suggested_facets"]
 
 
+@pytest.mark.parametrize("nofacets", (True, False))
+def test_nofacets(app_client, nofacets):
+    path = "/fixtures/facetable.json?_facet=state"
+    if nofacets:
+        path += "&_nofacets=1"
+    response = app_client.get(path)
+    if nofacets:
+        assert response.json["suggested_facets"] == []
+        assert response.json["facet_results"] == {}
+    else:
+        assert response.json["suggested_facets"] != []
+        assert response.json["facet_results"] != {}
+
+
 def test_expand_labels(app_client):
     response = app_client.get(
         "/fixtures/facetable.json?_shape=object&_labels=1&_size=2"