New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom templates directory in sub-folder not usable #41

Closed

rclement opened this issue May 10, 2021 · 0 comments · Fixed by #42

Contributor

rclement commented May 10, 2021 •

edited

Loading

When using a custom templates directory within a sub-folder, the templates are not used at runtime. For instance:

With a template folder at project/templates
Deploying using datasette publish vercel --template-dir project/templates ...

Inspecting the generated code using --generate-dir option yields:

A templates directory is generated at the root of the distribution folder (with the proper content)
Serverless function in index.py is referencing the templates folder with the wrong path:

app = Datasette(..., template_dir="project/templates", ...).app()

I think the fix is to simply set template_dir="templates" in index.py.

Note: it seems the same issue exists for plugins too.

The text was updated successfully, but these errors were encountered:

rclement mentioned this issue

Fix template_dir and plugins_dir paths in index.py #42

Merged

rclement mentioned this issue

template directory fails on non-default path #46

Open

simonw closed this as completed in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment