-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to specify a project (don't just default that to "datasette") #3
Comments
It looks like the BUT... I'm a bit confused by project linking: https://zeit.co/docs/now-cli#commands/now/project-linking |
Ideally, the user would create a new repository for their project and then import the repo so that deployments are created via git push. Then there is no need to install or learn the CLI. See https://vercel.com/docs/git for more info. |
My use-case here is a bit different from that - the idea with Datasette is to support people creating one-off deployments for specific databases, so asking them to set up a GitHub account for each one doesn't work (I want my users to be able to work without understanding or thinking about GitHub at all). I don't want to tell my users "in order to publish your database you need to first create a new repository for it on GitHub" - that doesn't fit the ad-hoc data publishing workflow I'm trying to encourage. I'm going to use the |
https://datasette-fixtures.simonw.now.sh was deployed with:
|
What happens if you use a project name that someone else is using already? Like https://hugo-hello-friend.now.sh/
That seems reasonable to me. |
Posted vercel/vercel#4021 - Please reconsider deprecating "name" in now.json |
I think there is some confusion. Project names don't equal domain names. You'll get a projectname.username.now.sh domain automatically but you can add additional domains, either .now.sh suffix or any custom domain. Visit the Domains tab on your project.
I see, then you can ignore my GitHub comment above. That being said, consider a user deploys once, then makes a change to their code, and deploys again. Typically they would want to promote one of these deployments to production and assign the production domain, probably the latest. How do you account for assigning production domains? (the git integration handles this when you merge to master, deploys from a PR are considered preview). |
Right now I'm running If the user doesn't want to go live straight away they can use the
Does that makes sense? I'm not 100% confident I understand the details of how |
Yes that makes sense. It sounds like the datasette default is the opposite for Now CLI. I think the word "live" here might be the source of confusion though because every deployment is "live" with ZEIT Now. The only distinguishable difference today is However, in the near future, there will be another difference. The |
Right now every deploy made with this project occurs in a Zeit project called "datasette" - and new deploys over-write the previous https://datasette.simonw.now.sh/
This is bad! Need to figure out a smart way to help users specify the project to be written to.
This is similar to how
--service
works indatasette publish cloudrun
- I ended up making--service
a required option there. Maybe--project
should be required here?The text was updated successfully, but these errors were encountered: