Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error messages when open CSV/database fails #46

Closed
simonw opened this issue Sep 3, 2021 · 1 comment
Closed

Show error messages when open CSV/database fails #46

simonw opened this issue Sep 3, 2021 · 1 comment
Labels
electron-wrapper Features that go in the Node.js/Electron code usability

Comments

@simonw
Copy link
Owner

simonw commented Sep 3, 2021

Currently it fails silently and logs to the console.

@simonw simonw added electron-wrapper Features that go in the Node.js/Electron code usability labels Sep 3, 2021
@simonw simonw added this to the First public installer release milestone Sep 3, 2021
@simonw simonw closed this as completed in 8963bd1 Sep 3, 2021
@simonw
Copy link
Owner Author

simonw commented Sep 3, 2021

New error message display looks like this:

Datasette__temporary_and_datasette-app_—_Electron_Helper__Renderer__◂_npm_start_TMPDIR__var_folders_wr_hn3206rs1yzgq3r49bz8nvnh0000gn_T__XPC_FLAGS_0x0_—_170×72

Using this code:

datasette-app/main.js

Lines 294 to 298 in 8963bd1

dialog.showMessageBox({
type: "error",
message: "Error opening CSV file",
detail: responseJson.error
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron-wrapper Features that go in the Node.js/Electron code usability
Projects
None yet
Development

No branches or pull requests

1 participant