Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements file #105

Open
tskisner opened this issue Feb 3, 2021 · 4 comments
Open

Add requirements file #105

tskisner opened this issue Feb 3, 2021 · 4 comments
Assignees

Comments

@tskisner
Copy link
Member

tskisner commented Feb 3, 2021

Hosting sotodlib on PyPI is a work in progress, pending so3g/spt3g work. However, when pip installing sotodlib we could already provide a requirements.txt file that eases the installation / verification that dependencies are present.

@tskisner tskisner self-assigned this Feb 3, 2021
@kmharrington
Copy link
Member

Could we revisit this? We need a requirements file for the docker install of sotodlib that goes inside of the sodetlib docker image.

A couple notes:

  • @jlashner Does the docker image building automatically look for requirements files and install those packages?
  • Is toast ever going to be a requirement for sotodlib? I believe we decided on no but want to make sure we're still good with that. Because we definitely don't want to require toast on the smurf servers.

@kmharrington
Copy link
Member

In particular this error shows up because our filtering functions need pyfftw but that's not installed in the sodetilb docker. But I think adding / using the requirements file is actually the correct way to fix that problem

@kmharrington
Copy link
Member

Does this part of setup_opts effectively work as a requirements file? https://github.com/simonsobs/sotodlib/blob/master/setup.py#L49

@tskisner
Copy link
Member Author

tskisner commented Aug 26, 2022

The long story about requirements files and setup.py is here:
https://packaging.python.org/en/latest/discussions/install-requires-vs-requirements/#requirements-files
https://caremad.io/posts/2013/07/setup-vs-requirement/

But for our purposes (assuming all requirements are listed in setup.py) we could just add a requirements.txt file that had:

--index-url https://pypi.python.org/simple/

# By default, use our abstract dependencies in setup.py for the
# concrete dependencies from PyPI.
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants