Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preprocess: Patch over missing iir_params #1036

Open
msilvafe opened this issue Nov 21, 2024 · 1 comment
Open

Preprocess: Patch over missing iir_params #1036

msilvafe opened this issue Nov 21, 2024 · 1 comment

Comments

@msilvafe
Copy link
Contributor

We've identified the reason for missing iir params and have put some fixes in place so that it doesn't happen in the future. However we need a fix in place to use/ignore this data that. The short term solution is to add a preprocess method that handles the behavior when iir_params are missing (either cut those detectors or fill them with a config specified default if its determined that its safe). The longer term solution will be an attachable obsdb and custom loader that applies a fix function. This issue and the short/long-term solutions are discussed in more detail in issue #969 . This issue is for tracking the short-term preprocess solution.

@msilvafe
Copy link
Contributor Author

msilvafe commented Dec 4, 2024

Its not going to be possible to cut all detectors since that'll fail at the further steps in the pipeline so would require us to add some sort of check after each pipe.select step which would exit the pipe if dets were cut to zero. That sounds like a reasonable thing to add but is a bit more infrastructure. A simpler short term solution which works with the current preproc structure is to have a logic check for what platform/wafer/time range etc is valid to fill with defaults and fill those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant