Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale of y axis in README plot is unclear #2

Closed
simonpcouch opened this issue Jun 6, 2024 · 1 comment
Closed

scale of y axis in README plot is unclear #2

simonpcouch opened this issue Jun 6, 2024 · 1 comment

Comments

@simonpcouch
Copy link
Owner

From @topepo:

in the readme, does the last plot (rss usage) have log units on the y-axis? It looks like it but the code doesn't show that.

bench automatically applies bench::scale_y_bench_bytes under the hood, but may be worth just added that line explicitly so folks know where it comes from.

syrup/README.md

Lines 167 to 175 in dc2b51d

res_mem %>%
filter(ppid == worker_ppid | pid == worker_ppid) %>%
ggplot() +
aes(x = id, y = rss, group = pid) +
geom_line() +
scale_x_continuous(breaks = 1:max(res_mem$id))
```
<img src="man/figures/README-plot-mem-1.png" width="100%" />

@simonpcouch
Copy link
Owner Author

Closing in favor of r-lib/bench#144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant