Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bir Tawil disputed area 21°52′9″N 33°44′52″E #8

Open
tforward opened this issue Dec 8, 2017 · 4 comments
Open

Bir Tawil disputed area 21°52′9″N 33°44′52″E #8

tforward opened this issue Dec 8, 2017 · 4 comments

Comments

@tforward
Copy link

tforward commented Dec 8, 2017

Bir Tawil disputed area

Wiki - Bir Tawil

Currently Returns nothing should return "Terra Nullius"

@simonepri
Copy link
Owner

simonepri commented Dec 8, 2017

@tforward Thank You for the issue!!

When I was working on the map some months ago I've noticed these two holes of land:
image
image
but I was unable to find information about them, so thank you for the video.

Anyway the package returns only countries that owns a country code.
Here you can find the list of all official country codes released.

Any ideas on how we can include this non-official area?

@tforward
Copy link
Author

tforward commented Dec 8, 2017

Only thing I could think of is have if the ISO country code returns NULL and then if IS Sea also returns NULL then another function runs which compares the area to a exception set of polygons that have custom values for them. This is a pretty edge case scenario and there are many more weird boarders out there, and exclaves are another can of worms. Again pretty edge case but FYI

@simonepri
Copy link
Owner

I think it would be really interesting to list all these "weird boarders" in the Readme.
We should also include all the disputed countries as a reference.

Are you interested in helping me?

@tforward
Copy link
Author

tforward commented Dec 8, 2017

I suppose.

Also, thinking about it a bit more it may be easier than I initially thought, however somewhat depends on the data you're using.

Are the holes in the data always these "Terra Nullius" areas?

If yes, then don't need to bother with the polygon intersects could just use the empty space!

If ISO country code is null and ISSea() is null
return "Terra Nullius"

Kinda feels like an easter egg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants