fix: skip nested markup containers

simon360 · Dec 11, 2018 · efa6060 · efa6060
1 parent 9d78582
commit efa6060
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/packages/react-from-markup/src/rehydrator.ts b/packages/react-from-markup/src/rehydrator.ts
@@ -75,7 +75,13 @@ export default async (
   const roots = Array.from(
     // TODO: allow setting a container identifier so multiple rehydration instances can exist
     container.querySelectorAll("[data-react-from-markup-container]")
-  );
+  ).reduce((acc: Element[], root: Element) => {
+    // filter roots that are contained within other roots
+    if (!acc.some(r => r.contains(root))) {
+      acc.push(root);
+    }
+    return acc;
+  }, []);
 
   // TODO: solve race condition when a second rehydrate runs