Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

API Documentation on how to create the wallet files, HD wallets #2

Closed
eddywm opened this issue Jun 9, 2018 · 8 comments
Closed

API Documentation on how to create the wallet files, HD wallets #2

eddywm opened this issue Jun 9, 2018 · 8 comments

Comments

@eddywm
Copy link
Contributor

eddywm commented Jun 9, 2018

It would be great if you could add more documentation on how to create a fresh new wallet.

All the interesting stuffs like HD Wallets, Mnemonic recovery, ...
I'd really like to see if I can use this lib in my flutter application.

@simolus3
Copy link
Owner

simolus3 commented Jun 9, 2018

Hi. This library does not support 'fancy' wallet stuff yet, only some simple methods dealing with the private key directly. But I'll look into adding support for more sophisticated wallets if you need it.

@eddywm
Copy link
Contributor Author

eddywm commented Jun 9, 2018

Hi @simolus3 I may even be willing to contribute to this lib.

I have been developping wallets on the Android platform prior to discovering Flutter months ago, now I can't think a mobile development world without Flutter and all the benefits it brings in terms of dev time and productivity.

@simolus3
Copy link
Owner

simolus3 commented Jun 9, 2018

Sounds great, I'd appreciate it much if you could invest some of your time in this project!

@eddywm
Copy link
Contributor Author

eddywm commented Jun 9, 2018

Are you planning to add support for those fancy wallet stuff
If so I can help since I have a decent understanding of Mnemonic derivations and the HD wallets for the bitcoin blockchain, it might be an opportunity for me to understand the Ethereum way of doing these stuffs.

@simolus3
Copy link
Owner

simolus3 commented Jun 9, 2018

I am. However, I've already started implementing wallet loading and decryption following this standard, so I think the best way here would be to wait until I've published the basic code dealing with wallets (should only take 1-2 from now, I hope). After that, you can add support for Mnemonics or more sophisticated use-cases of Wallets into this library if you want to.

@eddywm
Copy link
Contributor Author

eddywm commented Jun 9, 2018

Great !

@simolus3
Copy link
Owner

I've published an update with wallet support to this repository, but its not out on pub yet so that I can get some feedback as it breaks backwards compatibility.
Check the readme for details on how wallet support is designed in this library. Let me know if that's helpful for you. It does not contain anything dealing with mnemonics, just the minimum support for the Web3 Secret Storage Definition.
If you want to try this version of the library, change the dependency to this:

dependencies:
  web3dart:
    git: https://github.com/simolus3/web3dart.git

@eddywm
Copy link
Contributor Author

eddywm commented Jun 11, 2018

Excellent I have started to try it, I have just realized the type mismatch error that was surfacing is now fixed and a couple of API changes you have made.

On the other news, I started the mnemonic generation work following the web3j and others, and I have been able to get somewhere.
I was just waiting for you to publish these changes to propose a merge request in the development branch so that you can see what I have been doing and whether you can improve somwhere ( I'm still learning the idiomatic Dart . ).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants