Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impossible de contribuer à cause des droits git et des secrets en configuration #64

Closed
sebranly opened this issue Jul 13, 2019 · 4 comments
Closed

Impossible de contribuer à cause des droits git et des secrets en configuration #64

sebranly opened this issue Jul 13, 2019 · 4 comments
Labels
question Further information is requested

Comments

@sebranly
Copy link
Contributor

sebranly commented Jul 13, 2019 •
edited
Loading

Problèmes

  • Étant curieux vis-à-vis de ce projet utilisant React Native que j'essaie de découvrir, j'ai suivi le README.md pour mettre en place le projet mais je n'ai pas pu avoir accès à l'application.
iOS Simulator via npm run ios iPhone réel via npm start
Screenshot 2019-07-13 at 14 32 25Screenshot 2019-07-13 at 14 32 19 Screenshot 2019-07-13 at 14 42 33

Voici l'output si c'est utile pour débugger :

Output
  • Input : npm start
  • Output :
...
Press ? to show a list of all available commands.
Logs for your project will appear below. Press Ctrl+C to exit.
Finished building JavaScript bundle in 4746ms.
Running application on Sebastien's iPhone.

L'application n'a pas été configurée correctement. Veuillez renseigner le fichier de configuration
- node_modules/expo/build/environment/muteWarnings.fx.js:26:24 in error
- node_modules/expo/build/launch/RootErrorBoundary.js:56:22 in componentDidCatch
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:15908:29 in callback
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:13857:16 in callCallback
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:13901:19 in commitUpdateEffects
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:13892:22 in commitUpdateQueue
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:15123:10 in commitLifeCycles
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:16636:8 in commitAllLifeCycles
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:93:15 in invokeGuardedCallbackImpl
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:318:36 in invokeGuardedCallback
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:16876:8 in commitRoot
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18501:17 in <unknown>
- node_modules/scheduler/cjs/scheduler.development.js:255:23 in unstable_runWithPriority
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18499:4 in completeRoot
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18427:21 in performWorkOnRoot
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18324:24 in performWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18285:14 in performSyncWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18169:19 in requestWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:17969:16 in scheduleWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18642:15 in scheduleRootUpdate
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:19512:20 in render
- node_modules/react-native/Libraries/ReactNative/renderApplication.js:61:34 in renderApplication
- node_modules/react-native/Libraries/ReactNative/AppRegistry.js:104:10 in run
- node_modules/react-native/Libraries/ReactNative/AppRegistry.js:198:26 in runApplication
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:366:47 in __callFunction
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:106:26 in <unknown>
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:314:10 in __guard
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:105:17 in callFunctionReturnFlushedQueue
* [native code]:null in callFunctionReturnFlushedQueue

Require cycle: src/services/Portail.js -> src/utils/Generate.js -> src/components/Articles/Article.js -> src/services/Portail.js

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
- node_modules/expo/build/environment/muteWarnings.fx.js:17:23 in warn
- node_modules/metro/src/lib/polyfills/require.js:115:8 in metroRequire
* src/components/Articles/Article.js:19:0 in <unknown>
- node_modules/metro/src/lib/polyfills/require.js:331:6 in loadModuleImplementation
* src/utils/Generate.js:9:0 in <unknown>
- node_modules/metro/src/lib/polyfills/require.js:331:6 in loadModuleImplementation
* src/services/Portail.js:15:0 in <unknown>
- node_modules/metro/src/lib/polyfills/require.js:331:6 in loadModuleImplementation
* src/screens/AppLoader.js:22:0 in <unknown>
- node_modules/metro/src/lib/polyfills/require.js:331:6 in loadModuleImplementation
* App.js:22:0 in <unknown>
- node_modules/metro/src/lib/polyfills/require.js:331:6 in loadModuleImplementation
- node_modules/expo/AppEntry.js:4:0 in <unknown>
- node_modules/metro/src/lib/polyfills/require.js:331:6 in loadModuleImplementation
- node_modules/metro/src/lib/polyfills/require.js:197:45 in guardedLoadModule
* null:null in global code

Warning: %s: Error boundaries should implement getDerivedStateFromError(). In that method, return a state update to display an error message or fallback UI., RootErrorBoundary
- node_modules/expo/build/environment/muteWarnings.fx.js:26:24 in error
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:638:36 in warningWithoutStack
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:15918:16 in callback
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:13857:16 in callCallback
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:13901:19 in commitUpdateEffects
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:13892:22 in commitUpdateQueue
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:15123:10 in commitLifeCycles
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:16636:8 in commitAllLifeCycles
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:93:15 in invokeGuardedCallbackImpl
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:318:36 in invokeGuardedCallback
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:16876:8 in commitRoot
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18501:17 in <unknown>
- node_modules/scheduler/cjs/scheduler.development.js:255:23 in unstable_runWithPriority
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18499:4 in completeRoot
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18427:21 in performWorkOnRoot
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18324:24 in performWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18285:14 in performSyncWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18169:19 in requestWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:17969:16 in scheduleWork
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:18642:15 in scheduleRootUpdate
- node_modules/react-native/Libraries/Renderer/oss/ReactNativeRenderer-dev.js:19512:20 in render
- node_modules/react-native/Libraries/ReactNative/renderApplication.js:61:34 in renderApplication
- node_modules/react-native/Libraries/ReactNative/AppRegistry.js:104:10 in run
- node_modules/react-native/Libraries/ReactNative/AppRegistry.js:198:26 in runApplication
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:366:47 in __callFunction
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:106:26 in <unknown>
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:314:10 in __guard
- node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:105:17 in callFunctionReturnFlushedQueue
* [native code]:null in callFunctionReturnFlushedQueue

Je pense que c'est lié aux '' dans config.example.js (que j'ai copié tel quel vers config.js, auquel cas je comprends que les secrets soient gardés... secrets). Mais du coup ça empêche toute contribution extérieure à ce projet open-source, ce qui est dommage 🤔

  • Aussi, j'aimerais un accès restreint afin de créer au moins une PR d'une nouvelle branche feature/readme-setup vers develop. Mais ça bloque au git push origin à cause de remote: Permission to simde-utc/utc-mobile.git denied to sebranly.. Quelqu'un peut-il me donner un tel accès (limité) ? J'ai apporté des modifications au README.md.

Merci !
@sebranly
Copy link
Contributor Author

L'application n'a pas été configurée correctement. Veuillez renseigner le fichier de configuration dans l'output => checkEnvVariables dans App.js donc c'est bien ça.

@sebranly sebranly changed the title Erreur lors du lancement de l'application et impossible de contribuer Impossible de contribuer à cause des droits git et des secrets en configuration Jul 13, 2019
@NastuzziSamy
Copy link
Contributor

Salut @sebranly , merci de t'intéresser déjà au projet ! :)

Alors, oui du coup les configs sont secrètes, je vais peut-être réfléchir pour intégrer un config dev, mais je garanti pas d'avoir une idée fonctionnelle.

Pour la contribution, merci déjà ! Le projet appartenant au SiMDE, il faut être membre (je gère cette liste de membre) pour pouvoir pusher directement sur le repo. Pour faire une PR en tant qu'exté, il faut fork le projet, faire les modifs et proposer un merge depuis :)
Tu as l'aide github pour faire ça

@NastuzziSamy NastuzziSamy added the question Further information is requested label Jul 13, 2019
@sebranly
Copy link
Contributor Author

Super merci pour la réponse rapide, je vais faire le fork demain midi quand j’aurai de nouveau accès au PC

@NastuzziSamy
Copy link
Contributor

Je ferme cette issue et j'en ai créé 2 autres:

@sebranly sebranly mentioned this issue Jul 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NastuzziSamy @sebranly