sass-lint was abandoned 5 years ago

[emteknetnz]

We have an ancient version of sass-lint in @silverstripe/webpack-config which triggers dependabot alerts due to some of its own dependencies, which is annoying because it's only a dev dependency so there's no risk to production sites. sass-lint was abandoned 5 years ago, we're already on the latest version of it

We should migrate to something else, probably stylelint

Acceptance criteria

• CMS 5 webpack config is updated to use a supported library to lint its stylesheets.
• CMS 5 eslint config is updated to use a supported library to lint its stylesheets.
• CMS 5 supported modules are updated to use the latest version of our cms 5 webpackconfig and eslint config.
• Any linting change are addressed to make sure the builds are green

Related

• Change sass-lint for stylelint silverstripe-admin#1437

PRs

• MNT Replace sass-lint with stylelint #71
• MNT Replace sass-lint with stylelint eslint-config#22
• MNT Add stylelint to eslint module eslint-config#23
• MNT Replace sass-lint with stylelint silverstripe-admin#1727
• MNT Replace sass-lint with stylelint silverstripe-elemental-bannerblock#141
• MNT Replace sass-lint with stylelint silverstripe-asset-admin#1454
• MNT Replace sass-lint with stylelint silverstripe-cms#2929
• MNT Replace sass-lint with stylelint silverstripe-blog#752
• MNT Replace sass-lint with stylelint silverstripe-contentreview#229
• MNT Replace sass-lint with stylelint silverstripe-campaign-admin#299
• MNT Replace sass-lint with stylelint silverstripe-login-forms#171
• MNT Replace sass-lint with stylelint silverstripe-segment-field#105
• MNT Replace sass-lint with stylelint silverstripe-linkfield#277
• MNT Replace sass-lint with stylelint silverstripe-userforms#1282
• MNT Replace sass-lint with stylelint silverstripe-sharedraftcontent#230
• MNT Replace sass-lint with stylelint silverstripe-elemental#1173
• MNT Replace sass-lint with stylelint bringyourownideas/silverstripe-maintenance#217
• MNT Replace sass-lint with stylelint symbiote/silverstripe-advancedworkflow#525
• MNT Replace sass-lint with stylelint silverstripe-gridfield-bulk-editing-tools#275
• MNT Replace sass-lint with stylelint silverstripe-admin#1731
• MNT Replace sass-lint with stylelint silverstripe-contentreview#230
• MNT Replace sass-lint with stylelint silverstripe-login-forms#172

NEW PRs

• MNT Replace sass-lint with stylelint silverstripe-mfa#535
• MNT Replace sass-lint with stylelint silverstripe-session-manager#188
• MNT Replace sass-lint with stylelint silverstripe-tagfield#285
• MNT Replace sass-lint with stylelint silverstripe-totp-authenticator#151
• MNT Replace sass-lint with stylelint silverstripe-webauthn-authenticator#175
• MNT Replace sass-lint with stylelint silverstripe-externallinks#123
• MNT Replace sass-lint with stylelint silverstripe-frameworktest#173
• MNT Replace sass-lint with stylelint silverstripe-gridfieldqueuedexport#103
• MNT Replace sass-lint with stylelint silverstripe-lumberjack#143
• MNT Replace sass-lint with stylelint silverstripe-realme#136
• MNT Replace sass-lint with stylelint silverstripe-subsites#566

Additional task

• Remove stylelint warnings  .github#228

Note

Disabled rules were excluded according to the principle that the more errors, the greater the likelihood that this rule was not previously supported in the module. But they still require review in each module.

[maxime-rainville]

Random questions:

• I'm assuming this can be done in a minor since those are dev dependencies?
• Do we know why this wasn't flag in our CMS 5 dependency upgrades?

[emteknetnz]

• It's only dev dependencies so I think it could probably be done in a patch
• I don't know why it wasn't flagged in CMS 5 dep upgrades

[maxime-rainville]

Guy says: We did catch it, but decided it didn't matter. We're just fixing this now to shut up the dependabot alerts.

[GuySartorelli]

PRs merged

[sabina-talipova]

I reopen it, since I missed some modules.

[emteknetnz]

All merged and merged-up