Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-ordering fields does not work #1055

Closed
torleif opened this issue Apr 7, 2021 · 8 comments
Closed

Re-ordering fields does not work #1055

torleif opened this issue Apr 7, 2021 · 8 comments

Comments

@torleif
Copy link
Contributor

torleif commented Apr 7, 2021

Steps to reproduce:

  1. create a page with 10 or so fields
  2. reorder a field
  3. the reorder fails and times out

Our production system times out when someone reorders an item (by drag and dropping it in the CMS)

While on dev mode, I've got this response time:

image

this is on a modest page with about 10 or so form fields. I've taken a xdebug profile of a reorder, so i might be able to give some more insight into why it's failing

@torleif
Copy link
Contributor Author

torleif commented Apr 8, 2021

After a bit of digging, i've found:

  1. this does not affect a fresh install. It looks like it's one our extensions causing it (most likely a CWP extension, none of our codebase is being called after a profile)
  2. I've managed to address the issue by overriding modifying GridFieldEditableColumns.php handleSave() to use $item->write(false, false, false, false); as it seems to be one component on the page
  3. i don't know what component it is at the moment

@emteknetnz
Copy link
Member

It looks like it's one our extensions causing it

Is that an officially supported CWP extension? or one defined in your custom code base?

@torleif
Copy link
Contributor Author

torleif commented Apr 8, 2021

@emteknetnz I've tried it on a fresh CWP install. It does not appear to be affected.

So i guess the offending code is in our code base, or an extension we've got. feel free to close this. i think it warrants more investigation on our end

@brynwhyman
Copy link

Based on the above I'll close this issue. We can re-open it if a problem is found with a supported extension.

@torleif
Copy link
Contributor Author

torleif commented May 17, 2021

We're getting more angry CMS admins not being able to edit user forms. From what I can tell this is a duplicate of #773

@brynwhyman
Copy link

brynwhyman commented May 20, 2021

We're getting more angry CMS admins not being able to edit user forms. From what I can tell this is a duplicate of...

Hi @torleif, are your replication steps still the same of creating a page with 10 or so fields on a production system? You've mentioned using the CWP recipe, if that's the case I'm not sure how related to #773 it would be. For me, running the following can be done in under 7 seconds on a small CWP stack:

  • Use a user defined form page with 50 fields over five page breaks,
  • Change the field type of every field,
  • Change the field title of every field,
  • Save the page

@torleif
Copy link
Contributor Author

torleif commented May 30, 2021

@brynwhyman yes the steps were the same, a modest 10 or so fields. though a key step was re-ordering one or more of the fields

@brynwhyman
Copy link

Sorry forgot to mention that, I also tried replacing the 'Save the page' step with 'Re-order a field' and saw the same result of completing within ~7 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants