Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set framework logout_across_devices to false if session-manager is installed #65

Closed
5 tasks done
emteknetnz opened this issue Apr 21, 2021 · 1 comment
Closed
5 tasks done
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Apr 21, 2021

The recommendation from the investigation on the framework issue regarding UX weaknesses of logging out across devices on silverstripe/silverstripe-framework#9794 was that the default value of RememberLoginHash logout_across_devices should be changed from true to false if session-manager is installed

The original UX issue of logout_across_devices = true being a bit weird still remains. It should still stay in place if session-manager is not installed otherwise there is no way to logout malicious devices.

If session manager is installed, then set disable logout_across_devices = false as a default in config, though this also may be reset to true in project config

Note: No matter what value is set the logic in Revoke a single session will set logout_across_devices to false for the duration of a 'revoke' request, essentially ignoring the config value

ACs

  • The default value of logout_across_devices remains the same as true if session-manager is not installed
  • The default value of logout_across_devices is false if session-manager is installed
  • Projects can override this and set the default value of logout_accross_devices to true if session-manager is installed
  • Project documentation is updated to reflect this

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants