Race condition in port selection

[sminnee]

This bash script will break the find-a-free-port code

for x in 1 2 3 4 5; do  bin/serve --bootstrap-file framework/tests/behat/serve-bootstrap.php --open & done

The best fix is probably to retry on a new port if the php -S process fails to start.

[tractorcow]

Shouldn't serve take a parameter to an assigned port? Picking a random port will make behat configuration difficult, for instance, where a specific port is necessary.

[sminnee]

No - in the planned refactoring, Behat will be passed a Server object that has getHost(), getPort(), and getURL() methods. There won't be any need to load host details into behat.yml.

The code is given a preferred port number, and if that is available, it uses that. However, if that port is unavailable it autoincrements until it finds a free port.

[tractorcow]

Oh I see, sorry I was missing the context.

I would like to see less reliance on behat.yml to hard-code these settings, and more live-configuration such as this.

[dhensby]

still a problem?

[sminnee]

A brief review of the code suggests that it hasn't been fixed.