Missing option to disable logToFile

[CMeldgaard]

Im missing a option to disable logToFile in the abstract PaymentService class - i can see the idea when working locally, but because it logs to the silverstripe error log file, it also triggers Sentry error logging - meaning everytime a purchase is made i get 4 errors registered.

My suggestion would be to wrap $this->logToFile($output, $type); in a if-statement to check if config allows for logging.

[tractorcow]

You can probably try registering a NullLogger as the SilverStripe\Omnipay\Logger service.

I would really rather just have an option to throw exceptions rather than trying to mangle them (poorly) in code.

[tractorcow]

---
Name: logging-payment
After:
  - '#omnipay-logging'
---
# Disable garbage logging
SilverStripe\Core\Injector\Injector:
  SilverStripe\Omnipay\Logger:
    class: 'Psr\Log\NullLogger'

[kinglozzer]

I ran into the same issue (also with Sentry!) - options were to leave logging on and risk accidentally logging payment info in Sentry, or disable logging entirely and potentially leave exceptions un-reported. This is what I’ve come up with #229, and the config for it:

---
Name: payment-logging
After:
  - '#omnipay-logging'
---
SilverStripe\Core\Injector\Injector:
  SilverStripe\Omnipay\Logger:
    class: 'Psr\Log\NullLogger'
  SilverStripe\Omnipay\ExceptionLogger: '%$Psr\Log\LoggerInterface'