Broken build - graphql3 - manage files

[emteknetnz]

https://travis-ci.com/github/silverstripe/silverstripe-graphql/jobs/496679899

Screenshot
https://s3.amazonaws.com/silverstripe-travis-artifacts/silverstripe/silverstripe-graphql/222377700/496679900/screenshots/manage-files.feature_202.png

  Scenario: I can move a file through editing                                             # tests/behat/features/manage-files.feature:192

    When I click on the file named "folder1" in the gallery                               # SilverStripe\AssetAdmin\Tests\Behat\Context\FixtureContext::stepISelectGalleryItem()

    And I click on the file named "file1" in the gallery                                  # SilverStripe\AssetAdmin\Tests\Behat\Context\FixtureContext::stepISelectGalleryItem()

    Then I should see the "Form_fileEditForm" form                                        # SilverStripe\AssetAdmin\Tests\Behat\Context\FixtureContext::iShouldSeeTheForm()

    When I select "(Top level)" in the "#Form_fileEditForm_ParentID_Holder" tree dropdown # SilverStripe\Framework\Tests\Behaviour\CmsFormsContext::iSelectValueInTreeDropdown()

    And I press the "Save" button                                                         # SilverStripe\BehatExtension\Context\BasicContext::stepIPressTheButton()

    Then I should see the file named "file1" in the gallery                               # SilverStripe\AssetAdmin\Tests\Behat\Context\FixtureContext::iShouldSeeTheGalleryItem()

    And I should see the file named "folder1" in the gallery                              # SilverStripe\AssetAdmin\Tests\Behat\Context\FixtureContext::iShouldSeeTheGalleryItem()

    And I should not see "File cannot be found" in the "#Form_fileEditForm" element       # SilverStripe\AssetAdmin\Tests\Behat\Context\FeatureContext::assertElementNotContainsText()

Saving screenshot into /home/travis/build/silverstripe/silverstripe-graphql/vendor/silverstripe/asset-admin/artifacts/screenshots/manage-files.feature_202.png

PR's

• Fix asset-admin Editor ParentID/Location dropdown no longer showing any other options silverstripe-admin#1195
• Fix TreeDropDownField no longer displaying dropdown options silverstripe-admin#1196

[bergice]

Caused by silverstripe/silverstripe-admin@095b773

@maxime-rainville can you elaborate on what that commit does? Since it's blocking beta release I would be OK with reverting for now and doing a follow-up issue. Let me know what you think.

[emteknetnz]

I'd much prefer to "roll-forward" rather than "roll-back"

The pull-request that commit was on was green before it was merged https://github.com/silverstripe/silverstripe-admin/pull/1170/checks

What's causing the breakage exactly?

[bergice]

What's causing the breakage exactly?

Specifically this part seems to trigger it: silverstripe/silverstripe-admin@095b773#diff-962b5b46986393fbd25451f1639d6017065eff84dd0e9ddf7e3673022b172c1bR700-R727

[emteknetnz]

Linked PR has been merged