Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FORMS] Hidden field in ToggleCompositeField if validation error occurs #7822

Open
raissanorth opened this issue Feb 1, 2018 · 2 comments
Open

Comments

@raissanorth
Copy link
Contributor

Affected Version

SilverStripe 4+

Description

When an validation error occurs within the ToggleCompositeField the field is closed by default and the cause of the error is therefore hidden to the user.

I suggest to open the ToggleCompositeField if it contains fields with errors.

Steps to Reproduce

  • Create a ToggleCompositeField
  • Create a required field within the ToggleCompositeField
  • Submit the form without the required field filled
@chillu
Copy link
Member

chillu commented Feb 18, 2018

@sachajudd Can we apply the same solution as for tabs here? Or would it just be a matter of auto-expanding the toggle field when there's any validation errors? silverstripe/silverstripe-cms#2081

@sachajudd
Copy link
Contributor

sachajudd commented Feb 19, 2018

@raissanorth @chillu expanding the toggle field is a good idea see silverstripe/silverstripe-cms#2081 for designs which shows errors in multiple tabs but uses the ToggleCompositeField as an example 🙂

Design can also be found here: https://invis.io/V2FXGW5RSAH

@sminnee sminnee changed the title Hidden field in ToggleCompositeField if validation error occurs [FORMS] Hidden field in ToggleCompositeField if validation error occurs Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants