Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary_fields in GridField escape html incorrectly #11200

Closed
2 tasks done
sunnysideup opened this issue Apr 17, 2024 · 4 comments
Closed
2 tasks done

summary_fields in GridField escape html incorrectly #11200

sunnysideup opened this issue Apr 17, 2024 · 4 comments

Comments

@sunnysideup
Copy link
Contributor

sunnysideup commented Apr 17, 2024

Module version(s) affected

5.x-dev

Description

See: https://github.com/sunnysideup/silverstripe-5-test-with-summary-fields

Packages (see composer file)

image

Relevant Code

image

Create company

image

List Company

image

How to reproduce

See: https://github.com/sunnysideup/silverstripe-5-test-with-summary-fields

The repo is a fresh install of SS. You can install this and then add a company with a logo. Then the GridField basically does not show the log, but instead it show the raw html (escaped).

Possible Solution

Can provide more details if required, but please review first.

More examples

image
image

Additional Context

Changed about a month or two ago.

Validations

  • Check that there isn't already an issue that reports the same bug
  • Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)
@GuySartorelli
Copy link
Member

GuySartorelli commented Apr 17, 2024

Please provide a text description of what exactly the problem is, and what the expected behaviour is.
Please include any images that help to demonstrate the problem.
Please provide any code as markdown-formatted code blocks rather than images so they can be copy-pasted for easy reproduction.
Please include clear step-by-step instructions for reproducing the bug.

A link to a repository is not a bug report. I'm sorry but the CMS Squad simply doesn't have enough time to look at your repository and figure out for ourselves what the problem is - please spell it out so we can easily prioritise this as appropriate.

@GuySartorelli
Copy link
Member

Can provide more details if required

Yes, please do.

@GuySartorelli
Copy link
Member

Please provide a text description of what exactly the problem is, and what the expected behaviour is.

This request is not optional - while I do appreciate you reporting a bug, it is very hard for me to understand what exactly the problem is without you describing what the problem is and what the expected bahaviour is.

Please provide any code as markdown-formatted code blocks rather than images so they can be copy-pasted for easy reproduction.

I have added this request to my earlier comment. Images of code are not useful, because I can't copy them into my IDE to validate I get the same results that you get.

Note that the repository you have provided is not useful to me in identifying what the problem is - I need to be able to understand what the problem is, and reproduce it locally myself from a fresh installation of Silverstripe CMS.

@sunnysideup sunnysideup changed the title URGENT: summary fields do not display correctly URGENT: summary fields in GridField escape html incorrectly Apr 17, 2024
@GuySartorelli GuySartorelli changed the title URGENT: summary fields in GridField escape html incorrectly Summary fields in GridField escape html incorrectly Apr 17, 2024
@sunnysideup sunnysideup changed the title Summary fields in GridField escape html incorrectly summary_fields in GridField escape html incorrectly Apr 17, 2024
@GuySartorelli
Copy link
Member

Having taken a glance at the screenshots, it looks like this is probably a duplicate of #11191.

I'm going to close it as a duplicate for now. If it isn't a duplicate, I'm going to need some words that explain to me why not.

@GuySartorelli GuySartorelli closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants