Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS 6: Make SearchFilter::matches() and ComparisonFilter::match() abstract #10933

Open
GuySartorelli opened this issue Aug 29, 2023 · 0 comments
Open

CMS 6: Make SearchFilter::matches() and ComparisonFilter::match() abstract #10933

GuySartorelli opened this issue Aug 29, 2023 · 0 comments
Labels
complexity/low impact/low type/api-break
Milestone
Cleanup later

Comments

@GuySartorelli
Copy link
Member

In #10925 two new methods were added which couldn't be abstract, because that would be a breaking change:

  • SearchFilter::matches()
  • ComparisonFilter::match()

We should make those methods abstract in CMS 6.

Acceptance criteria

  • The SearchFilter::matches() method is made abstract
  • The ComparisonFilter::match() method is made abstract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity/low impact/low type/api-break
Projects
None yet
Milestone
Cleanup later
Development

No branches or pull requests
1 participant
@GuySartorelli