Malformed keys in translation files

[emteknetnz]

During the latest translation run, some invalid keys were added where the key was merged with the namespace e.g.

nl.yml

  DataObject:
    php:
      SilverStripe\ORM\DataObjectGENERALSEARCH: 'Alles doorzoeken'

6b49b6c#commitcomment-116173471

To replicate, do a fresh install of 5.0 and add the following to app/_config.php

php

<?php

use SilverStripe\i18n\i18n;

i18n::set_locale('nl_NL');

The parent issue for all the translations run at this time is silverstripe/.github#50

Core issues is that there were some invalid keys added to source en.yml files, probably by i18nTextCollector.

I've done a search on sink searching for php. in en.yml files in a 4.13 sink install:

• https://github.com/silverstripe/cwp-agencyextensions/blob/2.8/lang/en.yml#L38
• https://github.com/silverstripe/silverstripe-admin/blob/1.13/lang/en.yml#L3
• https://github.com/silverstripe/silverstripe-asset-admin/blob/1.13/lang/en.yml#L6
• https://github.com/silverstripe/silverstripe-campaign-admin/blob/1.13/lang/en.yml#L3
• https://github.com/silverstripe/silverstripe-framework/blob/4.13/lang/en.yml#L3
• https://github.com/silverstripe/silverstripe-realme/blob/4.4/lang/en.yml#L3

ACs

1. Whatever caused the en.yml key pollution is identified and fixed (probably i18nTextCollector)
2. Translated keys + values are deleted from translation yml files in 4.13
3. TextCollectorTask is run on relevant 4.13 branches so that source en.yml keys are updated to the new and correct key
4. PR's are merged up to 4, 5.0 and 5
5. Merge the 2nd PR for realme
6. 2nd realme PR is merged up from 4.4 to 4 to 5.0 to 5
7. TextCollectorTask is run on relevant modules is completed
8. Translations are re-added to transifex using the new keys
9. tx pull is run for relevant modules in 4.13
10. 4.13 branches are merged-up to 4, 5.0 and 5
11. Patch releases are released for 4.13 and 5.0

New issues created

• Automatic PHP linting for invalid translation keys #10807

PRs

• Fix translation key for DataObject.GENERALSEARCH #10805
• MNT Update invalid translations cwp-agencyextensions#94
• MNT Update invalid translations silverstripe-admin#1518
• MNT Update invalid translations silverstripe-asset-admin#1364
• MNT Update invalid translations silverstripe-campaign-admin#267
• MNT Update invalid translations silverstripe-realme#104
• MNT Remove invalid translation silverstripe-realme#106

Second lot of PRs (step 9)

• ENH Update translations bringyourownideas/silverstripe-maintenance#197
• ENH Update translations silverstripe-gridfield-bulk-editing-tools#240
• ENH Update translations cwp-agencyextensions#96
• ENH Update translations silverstripe-elemental#1065
• ENH Update translations dnadesign/silverstripe-elemental-userforms#75
• ENH Update translations silverstripe-admin#1526
• ENH Update translations silverstripe-asset-admin#1367
• ENH Update translations silverstripe-assets#555
• ENH Update translations silverstripe-blog#713
• ENH Update translations silverstripe-campaign-admin#269
• ENH Update translations silverstripe-cms#2861
• ENH Update translations silverstripe-contentreview#199
• ENH Update translations silverstripe-documentconverter#48
• ENH Update translations silverstripe-elemental-bannerblock#113
• ENH Update translations silverstripe-elemental-fileblock#41
• ENH Update translations silverstripe-errorpage#85
• ENH Update translations silverstripe-externallinks#102
• ENH Update translations #10820
• ENH Update translations silverstripe-iframe#72
• ENH Update translations silverstripe-ldap#58
• ENH Update translations silverstripe-mfa#499
• ENH Update translations silverstripe-realme#108
• ENH Update translations silverstripe-registry#85
• ENH Update translations silverstripe-reports#164
• ENH Update translations silverstripe-session-manager#148
• ENH Update translations silverstripe-sharedraftcontent#200
• ENH Update translations silverstripe-siteconfig#141
• ENH Update translations silverstripe-spamprotection#98
• ENH Update translations silverstripe-subsites#525
• ENH Update translations silverstripe-taxonomy#93
• ENH Update translations silverstripe-totp-authenticator#124
• ENH Update translations silverstripe-userforms#1216
• ENH Update translations silverstripe-versioned#408
• ENH Update translations silverstripe-versioned-admin#294
• ENH Update translations silverstripe-versionfeed#86
• ENH Update translations silverstripe-webauthn-authenticator#142
• ENH Update translations symbiote/silverstripe-advancedworkflow#493
• ENH Update translations symbiote/silverstripe-gridfieldextensions#365
• ENH Update translations symbiote/silverstripe-queuedjobs#407
• ENH Update translations tractorcow-farm/silverstripe-fluent#802

JS Translations

• ENH Update JS Translations silverstripe-admin#1529

[emteknetnz]

I've had a look through the other translations done at the same time, https://github.com/silverstripe/silverstripe-realme/pull/103/files also looks to have the same issue

[michalkleiner]

PR #10805

[emteknetnz]

Once PR's are merged please reassign back to me so that I can continue at step number 4

[michalkleiner]

@emteknetnz PRs reviewed and merged

[emteknetnz]

There was another PR for realme that I just created where I initially missed a translation - this is step number 5. When this has been merged please reassign back to me and I'll continue at step number 6

[emteknetnz]

Have checked transifex - it automatically re-added the deleted translations after re-pushing the new keys as part of silverstripe/.github#57

Presumably it did this because we had a setting enabled in transifex to automatically add translations where they was a previous translations for a different source key where the source value was the same

[GuySartorelli]

PRs merged. Assigning back to @emteknetnz for next steps

[emteknetnz]

Have patch released all the things