CMS 5 beta regression: setter method not called when saving field through edit form

[chrispenny]

Affected Version

5.0.0-beta3

Description

• I have set up my Page with a basic text field
• I then create a setter method for that field
• Saving a value for this field through a CMS edit form should trigger the setter method(?)

Is Silverstripe 4 it does, but in Silverstripe 5 it does not.

Set up

Page.php:

class Page extends SiteTree
{
    private static array $db = [
        'MyTestField' => 'Varchar',
    ];

    public function setMyTestField($val)
    {
        $this->setField('MyTestField', strtolower($val));
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->insertAfter('Title', TextField::create('MyTestField'));

        return $fields;
    }
}

Silverstripe 4

Input value into field:

Value after page is saved:

Silverstripe 5

Input value into field:

Value after page is saved:
[no change to field value]

Working in both Silverstripe 4 and 5

Interestingly, if I create a test that explicitly sets a value to my field, then this correctly call my setter in both Silverstripe 4 and 5.

class PageTest extends SapphireTest
{
    public function testSetMyTestField(): void
    {
        $page = Page::create();
        $page->MyTestField = 'Uppercase Words Here';

        Debug::dump($page->MyTestField);
    }
}

Output in both major versions:

====================================================
PageTest.php:16 - App\Tests\PageTest::testSetMyTestField()

uppercase words here
====================================================

PRs

• FIX Ensure getters and setters are respected #10708

[GuySartorelli]

This is a direct result of #10614

Where saving values from formfields used to go through the full __set() pipeline, it's now only going through setField() which has caused this regression, since it's no longer checking for and subsequently calling the setter methods.

[emteknetnz]

Linked PR has been merged