Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using deprecated code in CMS 4 for kitchen-sink #10545

Closed
1 of 3 tasks
emteknetnz opened this issue Oct 12, 2022 · 0 comments
Closed
1 of 3 tasks

Stop using deprecated code in CMS 4 for kitchen-sink #10545

emteknetnz opened this issue Oct 12, 2022 · 0 comments

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Oct 12, 2022

silverstripe/recipe-kitchen-sink version of #10542

Acceptance criteria

  • Update all code paths in supported modules (silverstripe/kitchen-sink) so that deprecated code is no longer being called
  • Manually mark test targeting deprecated method so the developer running the test can choose to skip them. These tests will be later removed in Remove deprecated code in CMS 5 for kitchen-sink #10546
    • Only skip these tests when deprecation notices are enabled and the deprecation version is >= 5.0.0

Notes

Shared CI run with all the PRs below

PRs

@emteknetnz emteknetnz self-assigned this Oct 12, 2022
This was referenced Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants