PHP8.2 Support in CMS5 for core modules

[maxime-rainville]

The first alpha of PHP8.2 is available. It's meant to reach feature freeze on July 19.

Acceptance criteria

• We have a clearly documented way of running a dev environment on pre-release PHP8.2. That's mostly targeted toward the internal SIlverstripe dev team. You should be able to install PHP 8.2 just like any other version as it's now stable
• CMS5 core and supported module builds can run PHP8.2. << I've split off a [new issue for supported modules](PHP 8.2 Support in CMS5 for non-core modules #10618)
• Syntax/constructs deprecated in PHP8.2 are no longer used.

Notes

• Queued Job will probably hate the Dynamic Properties are deprecated, If it requires substantial refactor, split it off as a separate card.
• PHP 8.2: Dynamic properties deprecated, but are currently required for JobData? symbiote/silverstripe-queuedjobs#377

New issues created

• CMS 5 - Upgrade to webonyx/graphql-php v15 silverstripe-graphql#511 << Blocks PHP 8.2 support for us
• PHP 8.2 Support in CMS5 for non-core modules #10618

Third party issues created

• [VarExporter] PHP8.2 Deprecated dynamic properties created in LazyGhostTrait::__set() symfony/symfony#48637 << this may be a non-issue for us, I didn't see this warning during testing, however I did detect it doing a string search for dynamic properties for things that could potentially go wrong e.g. not covered by unit tests

Third party PRs

• PHP 8.2 support webonyx/graphql-php#1256 << PR was for 14.x - only 15 (in beta) is supported, have asked when stable for 15 is being released - for our policy we should technically be using a stable not a beta
• Use mb_encode_numericentity() for PHP 8.2 oscarotero/html-parser#4

CI Integration test

- https://github.com/emteknetnz/silverstripe-installer/actions/runs/3711071825

PRs

• NEW PHP 8.2 for CMS5 gha-generate-matrix#39 << Merge on the non-core PHP 8.2 card
• ENH PHP 8.2 support #10614
• MNT Make asset variant unit tests order agnostic silverstripe-assets#535
• FIX Handle a bool return type from DateTime::getLastErrors() silverstripe-versioned#386
• ENH PHP 8.2 support silverstripe-assets#533
• ENH PHP 8.2 support silverstripe-config#77
• DEP Update minimum version of oscarotero/html-parser #10628

[emteknetnz]

We're blocked on:

• webonyx/graphql-php v15 being tagged stable / us upgrading silverstripe/graphl to use v15
• oscarotero/html-parser PR being merged and tagged
• CMS 5 compatible kitchen-sink branches being available

I've reduced the scope of this issue to "core" modules only and I've created a new issue to handle kitchen-sink

Given that graphql is "core", even when we close this issue we still won't have core support for PHP 8.2 - though we should once we've completed the webonyx/graphql-php v15 issue

[GuySartorelli]

@emteknetnz Your external PR oscarotero/html-parser#4 has been merged and tagged - do we need to change the minimum depencency or are we okay with --prefer-lowest not being 8.2 compatible? I think just leave as is but wanna confirm.

If we don't need to change that, this can be closed.

[emteknetnz]

May as well update the minimum installable version #10628