Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Director::host doesn't fallback to BASE_URL #10156

Closed
1 task
emteknetnz opened this issue Nov 21, 2021 · 1 comment
Closed
1 task

Director::host doesn't fallback to BASE_URL #10156

emteknetnz opened this issue Nov 21, 2021 · 1 comment
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Nov 21, 2021

The host function uses alternate_base_url instead of just calling baseURL() (which itself uses alternative_base_url if it exists). This shoudl be changed so that if a site doesn't have alternate_base_url defined, it will now fall back to using the BASE_URL env variable

PRs

@emteknetnz emteknetnz changed the title Director::host doesn't use baseURL Director::host doesn't fallback to BASE_URL Nov 21, 2021
@emteknetnz emteknetnz self-assigned this Nov 21, 2021
@emteknetnz
Copy link
Member Author

On further inspection, as noted in the PR, BASE_URL via SS_BASE_URL is already used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant