ManyManyThroughList::removeAll() doesn’t respect filters

[kinglozzer]

Unlike DataList, HasManyList and ManyManyList, when using many-many-through ManyManyThroughList::removeAll() will discard all filters and remove everything:

// Works as expected, relation is removed for all items except those with IDs in the $processedIDs array
foreach ($venue->AccessOptions()->exclude(['ID' => $processedIDs]) as $option) {
    $venue->AccessOptions()->remove($option);
}

// Removes all related items, including those in the $processedIDs array
$venue->AccessOptions()->exclude(['ID' => $processedIDs])->removeAll();

Acceptance criteria

• Calling removeAll on a filtered ManyManyThroughList only remove relations for items matching the filter.

PRs

• FIX Correctly remove relations with ManyManyThroughList::removeall #10295

[maxime-rainville]

Probably worth back porting all the way back to 4.9.

[GuySartorelli]

only remove items matching the filter

Just to clarify: this doesn't remove the items, it removes the relations - and even then it's not removing the row from the through table, it's just setting the ID for one side of the relation to 0 (which IMO is absolutely not the correct behaviour).

I'm going to update this to use the same logic used by ManyManyList::removeAll() - it will create a new delete SQL query that removes the relevant entries from the through join table.

[sabina-talipova]

@maxime-rainville, I've done tests on my local and ran unit tests as well. I could merge if you don't have any other questions.

[maxime-rainville]

All happy