Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new blocks to a page doesn't change its modified status #527

Closed
robbieaverill opened this issue Nov 29, 2018 · 3 comments
Closed

Comments

@robbieaverill
Copy link
Contributor

Versions: SS 4.3.x-dev with elemental 3.2.x-dev OR elemental 4.0.x-dev

  • Create a new page
  • Publish the page with no blocks
  • Add three content blocks, all with "Version 1a" as the content
  • Save each block and return to the page

Expected: the page should indicate somehow that it is in a draft state, since the content for the page has changed and is not yet published

Actual: the page remains in an unmodified (no draft changes) and published state

image

@robbieaverill
Copy link
Contributor Author

Debugging info

Page ID: 13
Creation: create page in root of site tree, change name to "Elemental test page", save

Step one, add a block and save it

  • Page.ElementalAreaID remains as 15
  • ElementalArea.Version remains as 1

Step two, publish the page

  • Page.ElementalAreaID remains as 15
  • ElementalArea.Version is changed to 2

Step three, edit the block's content and save it

  • Page.ElementalAreaID remains as 15
  • ElementalArea.Version remains as 2

So it looks like the problem is that the ElementalArea's version is not increased when an element it owns is modified. If it were, we probably wouldn't have an issue.

@ScopeyNZ
Copy link
Contributor

ScopeyNZ commented Dec 1, 2018

I've raised an issue over on versioned that is related to this: silverstripe/silverstripe-versioned#195

@robbieaverill
Copy link
Contributor Author

I'm going to close this as a duplicate now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants