Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: make After/Before: 'vendor/module#name' work #25

Open
tractorcow opened this issue Nov 21, 2017 · 1 comment
Open

RFC: make After/Before: 'vendor/module#name' work #25

tractorcow opened this issue Nov 21, 2017 · 1 comment

Comments

@tractorcow
Copy link

Since modules can be installed in root, the path#name syntax won't always be valid, since the path could be empty (relative to base dir) and will thus fail. E.g. After: framework#core won't work if framework is in root.

My suggestion is to support composer name in before / after rules so that rules will function in an install-agnostic manner.

See discussion at #24 (comment)

@robbieaverill
Copy link
Contributor

My suggestion is to support composer name in before / after rules so that rules will function in an install-agnostic manner.

+1

@flamerohr flamerohr modified the milestones: Recipe 4.1.0, Recipe 4.2.0 Feb 7, 2018
@chillu chillu removed this from the Recipe 4.2.0 milestone May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants