Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anchors are always marked with ss-broken if not using Content Field #2393

Closed
blueo opened this issue Feb 27, 2019 · 3 comments
Closed

Anchors are always marked with ss-broken if not using Content Field #2393

blueo opened this issue Feb 27, 2019 · 3 comments

Comments

@blueo
Copy link

blueo commented Feb 27, 2019

The link tracking functionality marks all anchor links as broken (class ss-broken) if your content is not located on $page->Content. The logic appears to be in the parser on line 72.

$broken = !preg_match("/(name|id)=\"{$anchor}\"/", $page->Content);

So when using something like elemental, the check always fails. Might be easier to disable to the check for anchor links - or just check the page, in these cases. This could be a config option.

@robbieaverill
Copy link
Contributor

@maxime-rainville
Copy link
Contributor

The current link tracking implementation leaves a lot to be desired. We probably should have another look at it.

This is issue is related to this one #2327

@GuySartorelli
Copy link
Member

This is no longer the case. The logic was updated in #2697 to use getAnchorsOnPage().
Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants