Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP8 support #198

Closed
1 task done
emteknetnz opened this issue Jan 20, 2021 · 1 comment
Closed
1 task done

PHP8 support #198

emteknetnz opened this issue Jan 20, 2021 · 1 comment

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Jan 20, 2021

Blocked waiting for all the phpunit9 PRs to be merged

Get behat installable and running on a local environment running PHP8

This will require upgrading the behat/behat dependency from 3.2 to ^3.8 - https://github.com/Behat/Behat/releases/tag/v3.8.0

ACs

  • This module is PHP8 compatible
  • This change has been tested through a Travis CI build to prove it works - silverstripe/admin could be a good test case

PR

@emteknetnz
Copy link
Member Author

Running behat with php8 worked - https://github.com/emteknetnz/silverstripe-admin/runs/4134074742?check_suite_focus=true

Using this gha config on emteknetnz/silverstripe-admin

name: Module CI

on:
  push:
  pull_request:

jobs:
  ci:
    uses: silverstripe/github-actions-ci-cd/.github/workflows/[email protected]
    # this is for testing https://github.com/silverstripe/silverstripe-behat-extension/issues/198
    with:
      run_phpunit: false
      run_phplinting: false
      run_endtoend: true
      composer_require_extra: silverstripe/frameworktest:0.4.2
      extra_jobs: |
        - php: '8.0'
          endtoend: true

@emteknetnz emteknetnz removed their assignment Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants