Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify when to use modelTab vs modelClass in ModelAdmin - and use them correctly. #1769

Open
GuySartorelli opened this issue May 30, 2024 · 0 comments

Comments

@GuySartorelli
Copy link
Member

modelTab and modelClass are used interchangably right now, and it's not always clear which should be used at a given time. This can cause problems.

Related

Notes

  • This is intentionally very vague - it could be a matter of documenting best practice and following it, or it could be a matter of changing the API for ModelAdmin so it is more directly intuitive.

Acceptance criteria

  • Make clearer rules about when to use modelTab and when to use modelClass
  • Follow those rules in all relevant places in supported modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants