-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor formschema logic from LeftAndMain
into its own abstract class
#1762
Comments
7 tasks
This was referenced Nov 12, 2024
Merged
API Make AdminRegistrationController a subclass of AdminController
silverstripe/silverstripe-mfa#573
Merged
Merged
ENH Update code to reflect changes in silverstripe/admin
silverstripe/silverstripe-contentreview#267
Merged
Merged
Merged
@GuySartorelli Thinks are looking good, could you just do a final updated kitchen sink run just to make sure everything integrated correctly |
That's massive overkill considering the scope of the changes since the last run:
I'll do it just to avoid ping pong, but it's really not necessary here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently
LeftAndMain
is bloated with logic for setting up formschema, but that isn't needed by most of its subclasses. This should be moved into its own class so the logic is only available where it's needed, and to makeLeftAndMain
easier to maintain.Related
Notes
Acceptance Criteria
FormSchemaController
class is created, and is a subclass ofAdminRouteController
(see Refactoradmin/*
routing logic fromLeftAndMain
into its own abstract class #1761)LeftAndMain
to the new class (see this comment for recommendations about this)ModalController
is a subclass of the new controllerModalController
handles the routes which currently require creating a singleton ofLeftAndMain
for formschemasLeftAndMain
but only needs the formschema logic is made to subclass the new class instead (e.g.LinkFieldController
)PRs
CMS 5 PRs
After merging reassign to Guy so they can merge up and rebase the CMS 6 PRs
CMS 6 PRs
Kitchen sink CI
The text was updated successfully, but these errors were encountered: