1.12 horizontal scrollbar in split mode

[tiller1010]

This PR removed a style rule that prevented horizontal scrollbars when in split mode:
#1422

The scrollbar does not show in Firefox, but it does show in Brave and Edge.

Firefox

Brave

Edge

PRs

• Apply fix to prevent horizontal scrollbar in the CMS admin #1629

[StevenLantinga]

For anybody wondering: This is caused by the mode dropdown itself in the right bottom. Adding #preview-mode-dropdown-in-content .chosen-drop { right: 0; width: 160px; } fixed the issue.

[RVXD]

I guess this would be a minor change to fix? Issue has been open since jan 6. Is there any way I can help?
One note: the issue is also visible in non-split mode, so maybe change title of issue.

[lerni]

Use 🔥🦊❗ 😀
To make the suggested fix above also work in preview-mode, I figured

/* in 5.x we need to revert #7b430d4 and add the previous snippet bellow
https://github.com/silverstripe/silverstripe-admin/commit/7b430d4171da9608918190109b85e15260e0d626 */
.chosen-container:not(.chosen-container-active) {
	overflow: hidden;
}

.preview-mode-selector .chosen-drop {
	width: inherit;
	right: 0;
}

If that looks acceptable I would try do make build-env working, PR and also test it a bit more. To what branch:question: If 4.x, is build than done on up-merge for 5?

[RVXD]

Can this be implemented? Now all CMS's have a horizontal scrollbar. This is still visible in 5.1.

[GuySartorelli]

Because this is a very minor visual bug, the CMS Squad can't dedicate time to fixing this right now. If this is causing problems for you, I recommend opening a pull request that fixes it.

[RVXD]

Hi Guy, it is also a bug that is simple to fix, without much time/effort. I don't understand why you skip fixing these 'minor bugs' so easily. I will look into how to make a PR for a CSS change. This probably involves building the CSS from SCSS?

[GuySartorelli]

There are a lot of low impact bugs that would be quick to fix on their own - but if we tried to do all of them we wouldn't have much time to dedicate to high impact bugs or enhancements.

Low impact but easy to fix bugs are great opportunities for the community to provide contributions for exactly the reason that they won't (again, in isolation) take long to fix.

Yup, building the CSS from SCSS is necessary if you're doing a CSS change. There's information about how to do that in the contribution docs, but let me know if you get stuck.

[RVXD]

I understand, will look into it! Thanks, Guy.

[RVXD]

Nice work @lerni ! I tried it on:
Mac OSX: Chrome, Safari, Firefox
Windows: Chrome and Edge
Before this fix only in FF it was working without scrollbar, after this fix there is also no horizontal scrollbar in Chrome, Safari and Edge.

[tiller1010]

The solution from @lerni works for me, but I think it should be noted that this style is only necessary for browsers other than firefox. That way it doesn't get removed again.

[GuySartorelli]

PR merged. This will be automatically tagged by GitHub actions