Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMS 4.12: Archive admin is broken #1379

Closed
1 task done
GuySartorelli opened this issue Oct 7, 2022 · 2 comments
Closed
1 task done

CMS 4.12: Archive admin is broken #1379

GuySartorelli opened this issue Oct 7, 2022 · 2 comments
Labels
complexity/medium impact/high type/bug

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 7, 2022 •
edited
Loading

Archive admin doesn't load, because it overrides getManagedModels() and doesn't include a dataClass key.
There are likely other ModelAdmin subclasses that do this to, so instead of just patching archive admin, we should make ModelAdmin not assume that key will always be there.

Acceptance criteria

  • Archive Admin works again.

PRs

Notes:

It's probably worth spinning off a card for CMS 5 to officially require 'dataClass' being a key in the array.
@GuySartorelli GuySartorelli mentioned this issue Oct 7, 2022
Merged
@michalkleiner
Copy link
Contributor

@GuySartorelli PR approved and merged, did you want to do a patch release?

@GuySartorelli
Copy link
Member Author

Awesome, thank you.
A patch release wouldn't be appropriate in this case - the problem was only present in the 4 branch (aka 4.12) which hasn't had a stable release yet.

Closing as this has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity/medium impact/high type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michalkleiner @GuySartorelli