Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy nested menu items javascript and styling #1378

Closed
1 task done
GuySartorelli opened this issue Oct 6, 2022 · 1 comment
Closed
1 task done

Remove legacy nested menu items javascript and styling #1378

GuySartorelli opened this issue Oct 6, 2022 · 1 comment

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 6, 2022

There is some frankly broken styling with associated functionality for having nested CMS menu items.
This is in client/src/components/Menu/Menu.scss and client/src/legacy/LeftAndMain.Menu.js.
Adding nested CMS menu items isn't documented outside of a doc comment in the above noted js file.

Nested menu items are possible through a third part module which currently relies on this styling and javascript (which is the only reason I haven't removed it in CMS4).
This broken styling and dead js functionality should be removed - it can be reimplemented in the third-party module itself, since that's the only place I can find that uses it.

Acceptance criteria

  • Remove the broken css and js

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants