Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation warning icon broken in Firefox #1130

Closed
brynwhyman opened this issue Oct 4, 2020 · 4 comments
Closed

Validation warning icon broken in Firefox #1130

brynwhyman opened this issue Oct 4, 2020 · 4 comments

Comments

@brynwhyman
Copy link

Overview

Recently implemented validation warning icons are not displaying in Firefox correctly:

image

Versions:

silverstripe/admin 1.6.2

Replication steps

You'll need to create a custom field with a validation rule. Replication steps in the previous PR

@brynwhyman
Copy link
Author

Raising on behalf. Will come back with more details

@jareddreyerss
Copy link

Affected on:
Firefox (81.0.1) with macOS High Sierra (10.13.6)

@Cheddam
Copy link
Member

Cheddam commented Oct 4, 2020

This may be related to an issue we previously thought fixed - that the addition of new icons doesn't change the URL of the font files, meaning browsers may continue to cache the old version.

The fix for this didn't make it into a @silverstripe/webpack-config release until a couple of weeks ago, so the version used in admin may not yet contain it, leading to the regression in behaviour.

@Cheddam
Copy link
Member

Cheddam commented Oct 5, 2020

This should be fixed by #1133, which has been released as silverstripe/admin 1.6.3.

@Cheddam Cheddam closed this as completed Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants