Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: silverstripe/silverstripe-admin
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4986131e5f9c724abf03b3c8c2a54477a5437365
Choose a base ref
..
head repository: silverstripe/silverstripe-admin
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6c0deb133738cc4bad242e45ee07aa43dd91fd0b
Choose a head ref
Showing with 8 additions and 9 deletions.
  1. +1 −1 client/dist/js/bundle.js
  2. +7 −8 client/src/legacy/LeftAndMain.EditForm.js
2 changes: 1 addition & 1 deletion client/dist/js/bundle.js

Large diffs are not rendered by default.

15 changes: 7 additions & 8 deletions client/src/legacy/LeftAndMain.EditForm.js
Original file line number Diff line number Diff line change
@@ -57,14 +57,16 @@ $.entwine('ss', function($){
ignoreFieldSelector: '.no-change-track, .ss-upload :input, .cms-navigator :input'
},


/**
* Variable: ValidationErrorShown
* Boolean for tracking whether a validation error has been already been shown. Used because tabs can
* sometimes be inadvertently initialised multiple times, but we don't want duplicate messages
* (Boolean)
* sometimes be inadvertently initialised multiple times, but we don't want duplicate messages.
*/
ValidationErrorShown: false,
getValidationErrorShown: function() {
return Boolean(this.data('_validationErrorShown'));
},
setValidationErrorShown: function(value) {
this.data('_validationErrorShown', value);
},

/**
* Constructor: onmatch
@@ -96,9 +98,6 @@ $.entwine('ss', function($){
}
}

// Reset error display
this.setValidationErrorShown(false);

// TODO
// // Rewrite # links
// html = html.replace(/(<a[^>]+href *= *")#/g, '$1' + window.location.href.replace(/#.*$/,'') + '#');