ENHANCEMENT Register installed modules and files in composer.extra #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that removal is respected Fixes silverstripe#2
4 tasks
Fixes issue found in silverstripe#1
tractorcow
force-pushed
the
pulls/1.0/removable-resources
branch
from
e08413a to
db40866
Compare
tractorcow
force-pushed
the
pulls/1.0/removable-resources
branch
from
db40866 to
5fcff3b
Compare
This was referenced Jul 17, 2017
|
Requesting review by @sminnee :D |
tractorcow
commented
Jul 17, 2017
src/RecipeCommandBehaviour.php
Outdated
| * no default | ||
| * @return array | ||
| */ | ||
| protected function loadComposer($path, $default = null) |
There was a problem hiding this comment.
Note: I've replaced this with core composer library API.
flamerohr
suggested changes
Jul 24, 2017
| } | ||
| if ($result) { | ||
| $composerData = $result; | ||
| } |
There was a problem hiding this comment.
isn't this the same as if (!$result) { return; }? as it would be the same (except for the $this->resetComposer(); call) if any other falsey value was returned by $callable
There was a problem hiding this comment.
A result can be empty and non-false. A non-return would default to null, and imply that the data was modified by ref instead of being returned, hence the following assignment. This is different to an explicit false return which the phpdoc states is to short circuit the write.
flamerohr
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that removed assets and modules (which were once inlined) don't get re-installed later.
Fixes #2