Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add mikey179/vfsstream in CI - should be require-dev in composer.json #6

Open
GuySartorelli opened this issue Jun 13, 2022 · 1 comment

Comments

@GuySartorelli
Copy link
Member

mikey179/vfsstream is being added for every module, regardless of if it is needed or not. We ideally shouldn't just add a package here that most modules don't need, as it means we could use some API from it in a non-assets module and the tests will pass even though it's not a dependency in that module.

The package is "Required for any module/recipe that runs silverstripe/assets unit tests" - so the composer.json for those modules/recipes should have it as a dev dependency.

What's more, it is being added with the constraint ^1.6.10 in CI which is necessary for PHP 8.1 but silverstripe/assets has it constrained too loosely as ^1.6.

composer require mikey179/vfsstream:^1.6.10 --dev --no-update

@emteknetnz
Copy link
Member

This constraint is a require-dev of assets, though any meta packages like this recipe-core won't automatically install the require-dev of required packages, and assets is required by lots of meta packages

We should probably remove it from gha-ci and let builds fail on cron to see which meta-packages need it in require-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants