Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special fail on deprecation warnings job #33

Open
emteknetnz opened this issue Jul 12, 2022 · 1 comment
Open

Special fail on deprecation warnings job #33

emteknetnz opened this issue Jul 12, 2022 · 1 comment
Labels
type/enhancement

Comments

@emteknetnz
Copy link
Member

Get gha-generate-matrix to create a special job that only runs on the silverstripe account when using the latest version of installer, and only when using the maximum version of php. Get this to somehow upgrade E_DEPRECATED and E_USER_DEPRECATED php errors to something creates an exit code of 1 so the phpunit jobs fail.

May wish to add the following:

  • Only limit to running on the silverstripe account
  • Only limit to running on non-pull-request events
  • The equivalent of 'allow_failures' - not sure if that's possible - 'continue-on-error' might be the best we can do
@emteknetnz
Copy link
Member Author

Given silverstripe/silverstripe-framework#10542 - I don't think we want this any more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli