Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Document deprecations for template layer refactor #594

Merged
merged 1 commit into from
Oct 21, 2024
Merged

DOC Document deprecations for template layer refactor #594

merged 1 commit into from
Oct 21, 2024

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli
Copy link
Member Author

Linting failure is unrelated

@GuySartorelli GuySartorelli mentioned this pull request Oct 10, 2024
Closed
23 tasks
emteknetnz
emteknetnz requested changes Oct 16, 2024
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing SSViewer::execute_template() + SSViewer::execute_string()

@GuySartorelli GuySartorelli force-pushed the pulls/5/template-deprecations branch from b0bdc53 to b430ed9 Compare October 21, 2024 01:14
@emteknetnz
Copy link
Member

Still need to add SSViewer::execute_template() + SSViewer::execute_string(), and rebase

@GuySartorelli GuySartorelli force-pushed the pulls/5/template-deprecations branch from b430ed9 to adf2849 Compare October 21, 2024 21:53
@GuySartorelli
Copy link
Member Author

Oops! Sorry, I was so focused on updating the code PRs I forgot this had a requested change.
Updated now.

@emteknetnz emteknetnz merged commit 4fabad4 into silverstripe:5 Oct 21, 2024
2 of 3 checks passed
@emteknetnz emteknetnz deleted the pulls/5/template-deprecations branch October 21, 2024 23:50
catharsisjelly pushed a commit to catharsisjelly/silverstripe-developer-docs that referenced this pull request Nov 1, 2024
@GuySartorelli @catharsisjelly
DOC Document deprecations for template layer refactor (silverstripe#594)
1d1037a
catharsisjelly pushed a commit to catharsisjelly/silverstripe-developer-docs that referenced this pull request Nov 1, 2024
@GuySartorelli @catharsisjelly
DOC Document deprecations for template layer refactor (silverstripe#594)
742b6ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz