Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken builds #156

Closed
sabina-talipova opened this issue Nov 2, 2023 · 2 comments
Closed

Broken builds #156

sabina-talipova opened this issue Nov 2, 2023 · 2 comments
Assignees
Labels

Comments

@sabina-talipova
Copy link
Contributor

sabina-talipova commented Nov 2, 2023

Description

There was 1 failure:

  1. SilverStripe\Forms\Tests\HTMLEditor\HTMLEditorFieldTest::testFieldConfigSanitization
    Table is removed
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
-'<p>standard text</p><table><th></th><tr><td>Header</td></tr><tbody></tbody></table>'
+'<p>standard text</p><table><tbody><tr><th></th></tr><tr><td>Header</td></tr></tbody><tbody></tbody></table>'

/home/runner/work/recipe-kitchen-sink/recipe-kitchen-sink/vendor/silverstripe/framework/tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php:268
phpvfscomposer:///home/runner/work/recipe-kitchen-sink/recipe-kitchen-sink/vendor/phpunit/phpunit/phpunit:106
/home/runner/work/recipe-kitchen-sink/recipe-kitchen-sink/vendor/bin/phpunit:118

PR

@GuySartorelli
Copy link
Member

Reassigning to Sabina to check the build goes green.

@sabina-talipova
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants