-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run translations #153
Comments
You know you can make comments instead of weird inline comment right? :p |
First set merged - reassigning to Steve to do the next set |
@GuySartorelli I've run translations on the 4.13 branches. I got a bunch of "english" translations included for mfa + asset-admin, so I've marked those as draft and will probably tackle in a separate issue |
Splitting those off sounds okay to me. |
Have created silverstripe/silverstripe-tx-translator#23 to deal with the english in translation files issue |
This is an automatically created issue used to run translations every 3 months.
It was created by the
.github/workflows/translation-issue.yml
workflow in the silverstripe/.github repository.Triage instructions (Silverstripe Ltd CMS Squad)
type/enhancement
impact/low
affects/v4
affects/v5
NOTE
- The current instructions say to use the5
branch, but this results in some modules being given a whole minor release even though the only thing that has changed is translations. It may make more sense to instead use the latest patch branch (i.e.5.1
).- This would mean we aren't loading instructions to transifex for features that haven't been released. This is good because we may change those features before we tag a stable release.- This also means we only release minor releases for modules which have new features or enhancements, not just small translation changes.- If you agree with this, make a PR to this repository to update the instructions, and then follow the updated instructions.@GuySartorelli ^ Steve: Don't agree. Reason instruction have
5
is because it's for the FIRST run which is TX_PULL=0 TX_COLLECT=1 TX_PUSH=1 which means "Run textcollector and push source en.yml changes to transifix".The SECOND run TX_PULL=1 TX_COLLECT=0 TX_PUSH=0 is run on
4.13
and will pull down any new non en.yml translations e.g. de.ymlThat's very unlikely and even if that happens it's a very small downside
Implementation instructions:
IMPORTANT: Make sure you do the card for using the new prefix first!
5
tx-translator
README.md and do a TX_PULL=0 TX_COLLECT=1 TX_PUSH=1 run.4.13
tx-translator
README.md and do a TX_PULL=1 TX_COLLECT=0 TX_PUSH=0 run.5
. If this step has been automated then you do not need to do anything.PRs - Update source files
PRs - Update translation files
PRs - English translations (need to investigate further, probably split off its own issue)
The text was updated successfully, but these errors were encountered: