Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run translations #153

Closed
github-actions bot opened this issue Nov 1, 2023 · 5 comments
Closed

Run translations #153

github-actions bot opened this issue Nov 1, 2023 · 5 comments

Comments

@github-actions
Copy link

github-actions bot commented Nov 1, 2023

This is an automatically created issue used to run translations every 3 months.

It was created by the .github/workflows/translation-issue.yml workflow in the silverstripe/.github repository.

Triage instructions (Silverstripe Ltd CMS Squad)

  1. Put on the following labels:
    • type/enhancement
    • impact/low
    • affects/v4
    • affects/v5
  2. Move this issue to the "Ready" column on our internal zenhub board

NOTE

- The current instructions say to use the 5 branch, but this results in some modules being given a whole minor release even though the only thing that has changed is translations. It may make more sense to instead use the latest patch branch (i.e. 5.1).
- This would mean we aren't loading instructions to transifex for features that haven't been released. This is good because we may change those features before we tag a stable release.
- This also means we only release minor releases for modules which have new features or enhancements, not just small translation changes.
- If you agree with this, make a PR to this repository to update the instructions, and then follow the updated instructions.

@GuySartorelli ^ Steve: Don't agree. Reason instruction have 5 is because it's for the FIRST run which is TX_PULL=0 TX_COLLECT=1 TX_PUSH=1 which means "Run textcollector and push source en.yml changes to transifix".

The SECOND run TX_PULL=1 TX_COLLECT=0 TX_PUSH=0 is run on 4.13 and will pull down any new non en.yml translations e.g. de.yml

This would mean we aren't loading instructions to transifex for features that haven't been released. This is good because we may change those features before we tag a stable release.

That's very unlikely and even if that happens it's a very small downside

Implementation instructions:

IMPORTANT: Make sure you do the card for using the new prefix first!

  1. Create an install of kitchen-sink using the latest next-minor branch e.g. 5
  2. Also install silverstripe/tx-translator
  3. Follow the instructions in the tx-translator README.md and do a TX_PULL=0 TX_COLLECT=1 TX_PUSH=1 run.
  4. This may create lots of pull-requests. Paste links to these pull request on this issue.
  5. Once the pull-requests have been merged, create a new install of kitchen-sink using the oldest supported minor branch e.g. 4.13
  6. Also install silverstripe/tx-translator
  7. Follow the instructions in the tx-translator README.md and do a TX_PULL=1 TX_COLLECT=0 TX_PUSH=0 run.
  8. This will create lots of pull-requests. Paste links to these pull request on this issue.
  9. Once these pull-requests have been merged, merge them up all the way through to the next-minor branch e.g. 5. If this step has been automated then you do not need to do anything.
  10. Create new patch releases for all supported branches on all repositories that have new translations. If this step has been automated then you do not need to do anything.

PRs - Update source files

PRs - Update translation files

PRs - English translations (need to investigate further, probably split off its own issue)

@GuySartorelli
Copy link
Member

GuySartorelli commented Nov 3, 2023

You know you can make comments instead of weird inline comment right? :p

@emteknetnz emteknetnz removed their assignment Nov 3, 2023
@GuySartorelli
Copy link
Member

First set merged - reassigning to Steve to do the next set

@emteknetnz
Copy link
Member

@GuySartorelli I've run translations on the 4.13 branches. I got a bunch of "english" translations included for mfa + asset-admin, so I've marked those as draft and will probably tackle in a separate issue

@GuySartorelli
Copy link
Member

Splitting those off sounds okay to me.

@emteknetnz
Copy link
Member

Have created silverstripe/silverstripe-tx-translator#23 to deal with the english in translation files issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants