Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider disabling triggers on large processes #29

Closed
chrispenny opened this issue Oct 21, 2021 · 2 comments
Closed

Consider disabling triggers on large processes #29

chrispenny opened this issue Oct 21, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@chrispenny
Copy link
Member

EG: Performing a duplicate on a Page that has many Elements could cause issues if there are a large number of touches/cares.

Can we identify such actions, and find a way to not trigger our actions during those actions?

@chrispenny chrispenny added the enhancement New feature or request label Oct 21, 2021
@chrispenny
Copy link
Member Author

chrispenny commented Nov 4, 2021

I've had a bit of a play around with "large" processes such as duplicate().

I really didn't notice any slow down of the actions when I ran them on pages that had (roughly):

  • 10 Blocks each
  • 3 of the Blocks each contained between 5 and 10 Items (EG: Carousel Blocks)
  • Each Item had 1 Image
  • Half of the Items also had a Link

I think we could potentially create some sort of State and allow devs to enable/disable cache key generation during processes that they nominate, but I'd be keen to hear that it's a problem before we do that.

@chrispenny
Copy link
Member Author

Closing this, as we haven't had any complaints about bulk actions.

Anyone can please feel free to comment on here if they are having performance issues, and we'll have another look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant