Feature: Add support for many_many and through relationships #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrispenny
force-pushed
the
feature/many-many-support
branch
2 times, most recently
from
f829c5f to
6181816
Compare
chrispenny
force-pushed
the
feature/many-many-support
branch
from
6181816 to
dabb36e
Compare
adrhumphreys
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
I've read through the code and understand most of it, I think we are at a very complex point with the many many which is both nice from a dev using the library perspective (as we've solved a complex problem) but makes life trickier from a maintenance perspective.
I'm not sure how we make it simpler though, maybe we need to think about a high level doc explaining the inner workings or something to that effect to make life easier for other people looking into it
| if (array_key_exists($relation, $manyMany) && is_array($touchClassName)) { | ||
| $edge = $this->getTouchesManyManyThroughEdge($node, $relation, $touchClassName); | ||
|
|
||
| // There is a chance that there was no valid Edge (for a reason that we do understand, and did not |
There was a problem hiding this comment.
If we understand the reason we should state it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Closes #12