Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcircuit improvements #55

Open
bobh0303 opened this issue May 1, 2019 · 0 comments
Open

shortcircuit improvements #55

bobh0303 opened this issue May 1, 2019 · 0 comments

Comments

@bobh0303
Copy link
Contributor

bobh0303 commented May 1, 2019

The code in DesignSpace._makefont() that determines whether it is safe to use the master UFO rather than create an instance should work sufficiently for our current projects.

However, there are some additional tests that should be added to improve reliability of the choice.

Specifically,

  • in line 554:
for sub in ('kern', 'glyphs', 'info', 'lib', 'familyname', 'stylename', 'stylemapstylename', 'stylemapfamilyname'):

the first term should be kerning (there is no kern subelement in designspace)

  • Don't permit shortcircuit if any of:
  1. designspace document has a rules element
  2. the source element we want to use has a layer attribute or has glyph or kerning subelements.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant