Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate ttffautohint (including parameters) #44

Open
n7s opened this issue Feb 1, 2018 · 3 comments
Open

integrate ttffautohint (including parameters) #44

n7s opened this issue Feb 1, 2018 · 3 comments
Labels

Comments

@n7s
Copy link
Contributor

n7s commented Feb 1, 2018

please integrate ttfautohint into smith, with the ability to indicate the various parameters.

How about a font parameter of: ttfautohint_parms="-n -W" for example?

@nrsiward
Copy link
Contributor

nrsiward commented Mar 1, 2018

Example of how to integrate into wscript:

font(target = process(outfile, ...
			cmd("${TTFAUTOHINT} -n -W ${DEP} ${TGT}")),
	…
     )
def configure(ctx):
		ctx.find_program('ttfautohint')

We need to add a parameter to the font class so the above is not needed.

@mhosken
Copy link
Contributor

mhosken commented Mar 1, 2018

Do we want ttfautohint to be run even if there is no ttfautohint_parms? If not, then perhaps we should just call the attribute ttfautohint? Do we make smith dependent on ttfautohint or do we only run it if configure manages to find it?

@nrsiward
Copy link
Contributor

nrsiward commented Mar 1, 2018

There was no discussion at TM2018 about what to call the parameter to smith. I think ttfautohint sounds good and smith should only run ttfautohint if that parameter is present.

I don't want to make smith dependent on ttfautohint since it's unclear how many projects will use it. If configure cannot find it and the parameter is present, will it issue a clear warning? If so, then that's probably all that is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants