-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve how SLDR downloads langtag.json file #987
Comments
@jwickberg Don't we have that already? There's |
@ermshiperete I created this when I found that Paratext was starting slowly on some machines because of the download of the langtags.json file - this was made worse because the IF-MODIFIED-SINCE wasn't working which meant the file was always being downloaded. That was corrected on the server, but WSTech suggested we do the check a different way. |
I think what needs to happen:
|
When SLDR is initialized, it currently does a synchronous request to download the langtags.json file and this request can be slow on machines with slow internet connections.
It would be better if the download of the langtags.json file could be separated out from the initialization code and allow applications to decide when to make the call.
Also, the SLDR code currently uses the IF-MODIFIED-SINCE header and for a while this was broken on the server. It is working now, but WSTech would like us to switch to using the ETag method instead since this is now more common. They gave this as a reference: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/ETag
The text was updated successfully, but these errors were encountered: