Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Apparent bug in serializeArray() #506

Open
Blasterdude opened this issue May 16, 2023 · 1 comment
Open

[Bug] Apparent bug in serializeArray() #506

Blasterdude opened this issue May 16, 2023 · 1 comment

Comments

@Blasterdude
Copy link

Blasterdude commented May 16, 2023

Describe the bug
This line appears to be incorrect:
https://github.com/silkimen/cordova-plugin-advanced-http/blob/master/www/url-util.js#L73

It has the incorrect number of args and doesn't seem to make sense / match other similar lines. It currently reads:

parts.push(serializeObject(parentKey + '[]' + array[i], encode));

I believe it should be changed to:

parts.push(serializeObject(parentKey + '[]', array[i], encode));
@Blasterdude Blasterdude changed the title [Bug] [platform] Apparent bug in serializeArray() [Bug] Apparent bug in serializeArray() May 16, 2023
@Blasterdude
Copy link
Author

I'd like to open a PR for this but I keep getting 403s when I try to publish the branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant